Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create homepage UI for channels in zimui #225

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Create homepage UI for channels in zimui #225

merged 7 commits into from
Jun 17, 2024

Conversation

dan-niles
Copy link
Collaborator

@dan-niles dan-niles commented Jun 13, 2024

This PR adds the homepage for the new Vue.js UI. The following things were done:

Screenshots:
image
image

Closes #213
Closes #214
Closes #210

@dan-niles dan-niles self-assigned this Jun 13, 2024
@dan-niles dan-niles force-pushed the ui-revamp-homepage branch 4 times, most recently from af102d3 to b520bc1 Compare June 13, 2024 05:08
@dan-niles dan-niles changed the title Create homepage for channels in zimui Create homepage UI for channels in zimui Jun 13, 2024
@dan-niles dan-niles marked this pull request as ready for review June 13, 2024 12:04
@dan-niles dan-niles requested a review from benoit74 June 13, 2024 12:04
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first general comment is: well done, from a code perspective, there is very little to say (only few inline comments).

I tried to build a ZIM with the UI inside and it is working (only discovered #226 and #227 but these are "details")

From a higher level perspective, I wonder if we should fine-tune a little bit the UI, it is quite visible that you've deviated from original design. I'm however not sure it is the right moment to do it, mostly because I'm not sure that your current design is worse than original one. I suggest that we keep the design as-is for now, and we then organize a session with designers once the whole UI is ready and with a real channel to discuss the details that need to be fixed and the ones we do not care about. We should open an issue about this, something like "Fine-tune UI visual details"

.github/workflows/Tests.yml Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
zimui/src/assets/images/banner-placeholder.jpg Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@dan-niles dan-niles requested a review from benoit74 June 15, 2024 04:48
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@benoit74 benoit74 merged commit 690d22f into main Jun 17, 2024
7 checks passed
@benoit74 benoit74 deleted the ui-revamp-homepage branch June 17, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants